SQLinForm SQL Formatter
Isn't working as intended. I have setting such that all comma should be surrounded by SPACE, unwrapped, and left aligned. When there is SPACE after comma, it works. but when there is no SPACE after comma, it doesn't work.
e.g.
group by 1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16
(i.e. no space after comma) is producing
group by 1,2 , 3,4 , 5,6 , 7,8 , 9,10 , 11,12 , 13,14 , 15,16
It should produce this:
group by 1 , 2 , 3 , 4 , 5 , 6 , 7 , 8 , 9 , 10 , 11 , 12 , 13 , 14 , 15 , 16
Hi @jpotelle,
thanks for your feedback.
This issue is related to the fact that in Europe we use the comma as decimal-point. Therefore the parser will not split digits with a comma "inside". Now, reading your comment, I think that I should not check the decimalpoint-is-comma rule within "ORDER BY" and "GROUP BY". Will fix this with the next release
Regards
Guido
@admin that would explain why this also doesn't work right:
where mycolumn in (71,72, 81,82)
Is it feasible to check localization settings when dealing commas overall?
I just noticed this problem also with IN clauses (as @jpotelle notes above) , for example IN (1,2,3,4,5) is not formatted correctly but IN ('1','2','3','4','5') will be formatted correctly. I'm just commenting here to get automatically notified of updates, thanks!
@bbhulsey thanks for your feedback.
Did you alread gave the new option "Decimal point is Comma" a try and uncheck it?
Regards
Guido
Hello @admin, I did not. I was not aware of it. I have changed the option and all works well now. Thank you again!
